SMZ3: Fix removing items after sweeping state in pre_fill - #6348
Open
Mysteryem wants to merge 1 commit into
Open
SMZ3: Fix removing items after sweeping state in pre_fill#6348Mysteryem wants to merge 1 commit into
Mysteryem wants to merge 1 commit into
Conversation
SMZ3 would produce an 'all state' for dungeon filling purposes, but it would remove its dungeon items from the state *after* the state had already swept to pick up reachable items, meaning that the state could have collected items that were only reachable because the dungeon items were still collected into the state. This has been fixed by only performing the sweep after the dungeon items have been removed.
github-actions
Bot
added
the
waiting-on: peer-review
duckboycool
added
is: bug/fix
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
SMZ3 would produce an 'all state' for dungeon filling purposes, but it would remove its dungeon items from the state after the state had already swept to pick up reachable items, meaning that the state could have collected items that were only reachable because the dungeon items were still collected into the state.
This has been fixed by only performing the sweep after the dungeon items have been removed.
The deprecated
use_cacheargument passed toget_all_state(), that no longer does anything since its deprecation, has also been removed.How was this tested?
Only by running the unit tests