Options Creator: Checkbox Lists - #6350
Open
Alchav wants to merge 2 commits into
Open
Conversation
… when there are valid_keys
github-actions
Bot
added
affects: core
Contributor
|
Tickboxes for OptionList sounds like a WebHost bug to be honest. An OptionList allows duplicate elements, and the order of the elements in the list may have some meaning. Tickboxes are therefore not suitable to represent OptionList options. Edit: I made #6353 to track the WebHost issue . |
Contributor
Author
Changed the handling for OptionList options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
For OptionSet options with specified
valid_keys, the Options Creator shows a checkbox list with all of said valid keys.For OptionList options with specified
valid_keys, the Options Creator shows a dropdown menu to select valid keys to add to the list, and a button to remove them.How was this tested?
Creating a yaml with chosen valid keys items.
If this makes graphical changes, please attach screenshots.