Subnautica: Handle empty filler item weights with specific error - #6361
Open
Rooby-Roo wants to merge 1 commit into
Open
Subnautica: Handle empty filler item weights with specific error#6361Rooby-Roo wants to merge 1 commit into
Rooby-Roo wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
waiting-on: peer-review
Rooby-Roo
added
waiting-on: world-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6360.
A YAML that has an empty filler items distribution value now raises the error that previously existed to also catch negative values:
Options.OptionError: Filler Items Distribution needs at least one positive weight.I also turned it into an OptionError instead of a general Exception, since I was in there.
Tested on source as of time of PR. Generates successfully with the default value of this option, and fails with the above error when the example YAML in the above issue is used.
I don't play Subnautica, so I haven't tested anything of the sort with a Subnautica client. Not that this should even touch that.