Skip to content

CommonClient: Hint Tab Filtering - #6364

Open
EmilyV99 wants to merge 6 commits into
ArchipelagoMW:mainfrom
EmilyV99:hint-tab-filtering
Open

CommonClient: Hint Tab Filtering#6364
EmilyV99 wants to merge 6 commits into
ArchipelagoMW:mainfrom
EmilyV99:hint-tab-filtering

Conversation

@EmilyV99

@EmilyV99 EmilyV99 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What is this fixing or adding?

Filtering to the Hint Tab.

Note: This is build on top of #6139 (and is designed as a very similar system). That PR should be merged first before this one (then I can rebase this PR on main after that).

Mostly looking for feedback / assistance at this point.

  • Right-click a column header to open a dropdown for filtering. If the dropdown would be empty, it fails to open instead.
  • Dropdowns show every value currently in the column, allowing you to hide them by adding them to the denylist (deselecting them).
  • By default, nothing is denylisted (everything is visible). A single exception is made for the Status column, where Found hints are hidden by default (as has been commonly requested).
  • The Item column additionally has Classification based filters- allowing you to "Require" or "Hide" the Progression, Useful, or Trap flags- and you can additionally "Hide Filler" to hide items with no flags. Multiple Requires act as an AND, so Require: Progression + Require: Useful is requiring prog+useful combination specifically. There is a small divider below the classification filters, before the actual item-name filters appear.

Also, because it was a glaring issue with this, I fixed the kvui.py HoverBehavior not respecting widget overlap properly (now, if widgets overlap, only the topmost widget is considered to be hovered over, preventing tooltip bleed-through from under these dropdowns)

How was this tested?

Fiddling around with the filters and sorting on the hint tab

Known Issues (general kivy issues)

  • I don't like the dropdown opening animation. (That's just how dropdowns open right now... I would so prefer them to just appear, or at least appear faster, and maybe appear starting from the cursor or something - it feels so jarring how it animates in).
  • Tooltips appear through the dropdown for objects beneath it (This is just an issue with dropdowns right now- the only reason the Hint Status changing dropdown doesn't have the same issue as far as I can see is that it's far enough away from anything with a tooltip that it just doesn't overlap them)
    • Managed to fix this one by modifying HoverBehavior!
  • Scrolling in the dropdown feels slow (this is just how dropdowns are right now in this kivy settings)

Known Issues (specific issues re: this PR)

  • The kivy clock occasionally seems to scream Clock: Warning, too much iteration done before the next frame. Check your code, or increase the Clock.max_iteration attribute. Remaining events:. In my testing it happens specifically when opening the dropdown for the Status column. No idea why this happens, or why it would just be for that, there's nothing special about that one.

If this makes graphical changes, please attach screenshots.

General showcase:

2026-07-30.06-13-23.mp4

Fixed the tooltip HoverBehavior:

2026-08-04.15-42-42.mp4

@github-actions github-actions Bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant