CommonClient: Hint Tab Filtering - #6364
Open
EmilyV99 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Filtering to the Hint Tab.
Note: This is build on top of #6139 (and is designed as a very similar system). That PR should be merged first before this one (then I can rebase this PR on main after that).
Mostly looking for feedback / assistance at this point.
Statuscolumn, whereFoundhints are hidden by default (as has been commonly requested).Requires act as anAND, soRequire: Progression+Require: Usefulis requiring prog+useful combination specifically. There is a small divider below the classification filters, before the actual item-name filters appear.Also, because it was a glaring issue with this, I fixed the kvui.py
HoverBehaviornot respecting widget overlap properly (now, if widgets overlap, only the topmost widget is considered to be hovered over, preventing tooltip bleed-through from under these dropdowns)How was this tested?
Fiddling around with the filters and sorting on the hint tab
Known Issues (general kivy issues)
Tooltips appear through the dropdown for objects beneath it (This is just an issue with dropdowns right now- the only reason the Hint Status changing dropdown doesn't have the same issue as far as I can see is that it's far enough away from anything with a tooltip that it just doesn't overlap them)HoverBehavior!Known Issues (specific issues re: this PR)
Clock: Warning, too much iteration done before the next frame. Check your code, or increase the Clock.max_iteration attribute. Remaining events:. In my testing it happens specifically when opening the dropdown for the Status column. No idea why this happens, or why it would just be for that, there's nothing special about that one.If this makes graphical changes, please attach screenshots.
General showcase:
2026-07-30.06-13-23.mp4
Fixed the tooltip HoverBehavior:
2026-08-04.15-42-42.mp4