Test: flask duplicate route is now a ValueError - #6380
Open
black-sliver wants to merge 1 commit into
Open
Conversation
black-sliver
marked this pull request as ready for review
August 6, 2026 08:43
github-actions
Bot
added
the
waiting-on: peer-review
duckboycool
added
the
is: bug/fix
Jouramie
approved these changes
Aug 7, 2026
Jouramie
left a comment
Jouramie
left a comment
Collaborator
There was a problem hiding this comment.
I ran into those tests many times. Thanks for looking into it and finding the solution!
Did not test the tests, code LGTM.
| }) | ||
| try: | ||
| cls.app = get_app() | ||
| except AssertionError as e: |
Collaborator
There was a problem hiding this comment.
Is the old flask version still used? Do we still need to expect AssertionError?
Member
Author
There was a problem hiding this comment.
Yes, people that never run WebHost locally (to trigger an update), may still run tests locally with an old version of flask.
Jouramie
added
the
affects: webhost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Sadly our WebHostLib is a bit of a mess and needs a work-around in tests.
Flask changed this from an assertion to a ValueError at some point, so we need to update the TestBase to also detect the ValueError.
How was this tested?
#6379 fails without this because of the order the tests are instantiated/run in.