#68. First test added. Many things have to be reviewed after accept t…#77
Open
soygabimoreno wants to merge 1 commit into
Open
#68. First test added. Many things have to be reviewed after accept t…#77soygabimoreno wants to merge 1 commit into
soygabimoreno wants to merge 1 commit into
Conversation
soygabimoreno
requested review from
adrianlazaro8,
davthecodercom and
gabrielpozo
adrianlazaro8
approved these changes
Mar 24, 2020
|
|
||
| verify(observer).onChanged(MovieViewModel.UiModel.RequestMovies) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Imagino que estos comentarios están ahí para acabarlo en otro momento. Te comento una cosa molona que tiene github, por si no lo conocías: a la hora de crear una PR puedes marcarla como WIP, de forma que hasta que no confirmes que el trabajo ya está acabado no se pueda mergear ni se solicita review a los reviewers.
Weeeeeeeeeeeee!!! Primer test funcionandoooooooo!! =D=D
Grande Gabi! =)
Collaborator
Author
There was a problem hiding this comment.
Mola lo de WIP! No lo conocía. Lo de mergear está guay, pero sí que me hace falta review... jajaja
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am doing this PR for starting to review the branch.