Add test to MovieViewModel#79
Open
davthecodercom wants to merge 1 commit into
Open
Conversation
davthecodercom
requested review from
adrianlazaro8,
gabrielpozo and
soygabimoreno
| } | ||
|
|
||
| private fun handleMoviesResponse(movies: List<Movie>) { | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) |
Collaborator
There was a problem hiding this comment.
No conocía esto... mola!
Collaborator
Author
There was a problem hiding this comment.
jajaja, ya te digo, yo creo que es lo que mas uso en testing.
| import org.mockito.Mockito.* | ||
| import org.mockito.junit.MockitoJUnitRunner | ||
|
|
||
| @RunWith(MockitoJUnitRunner.Silent::class) |
Collaborator
There was a problem hiding this comment.
¿Para qué sirve lo de Silent?
Collaborator
Author
There was a problem hiding this comment.
Hay un error de logs de Mokito sobre extra stubs. he buscado y dicen que es un error de Mokito, asi que con Silent silencias esos extra logs.
davthecodercom
changed the title
adrianlazaro8
approved these changes
Apr 15, 2020
soygabimoreno
approved these changes
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porfavor, incluye este checklist basico para validar el pull request.
Nombre del branch:
Descripcion
Pull request checklist: