Conversation
- a safety check on binding range to handle fails on 1d params - fixed a string parsing problem I sometimes get
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I just happened to be working on this and saw you turned down your PR. I made my version purely through the slides on this on the official discord server (from 2 years ago and big thanks to Richard Niu) plus observing the behaviours on Inochi2d Creator (because I can't read dlang), continuing from your work. My understanding of it might not be perfect. Please try this out and see if it works on your test examples. I am not sure whether we discuss it here would still make it easy for maintainers to catch up to the code, because there's certainly alot behind the scenes that's not documented. I have certainly run out of my brain juice trying to work this out.
What I tested working so far, a simple Meshgroup containing Parts and a simple setting with nested Meshgroups with different deformation modes (dynamic/static). No real models yet because this currently suffers from a massive cpu bottleneck running them. It's way slower than Creator right now. Though it may be helpful to you as a starting point compared to figuring it out from the original codebase.