Inspector navigation fixes - #11
Merged
Merged
Conversation
ArcturusEmrys
force-pushed
the
inspector-navigation
branch
from
September 6, 2026 17:29
3e2b26c to
20dbc6d
Compare
…ows File Explorer
…source. Also, because of this, I had to restructure all our event handling to prevent reentrant event calls, because GTK loves reflecting events back at you. Actually I'm pretty sure the code before this was just straight-up broken anyway
Also prevent clicking on the same item from creating a new history entry.
ArcturusEmrys
force-pushed
the
inspector-navigation
branch
from
September 14, 2026 03:42
20dbc6d to
8874f67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a bunch of new navigation options in the inspector:
Additionally, this fixes a number of bugs with our back/forward implementation that were ultimately caused by reentrant event processing. That is, whenever we change tabs or select an item in response to an event, that in and of itself creates an event that we will wind up double-processing. I wound up having to introduce like three different event flags, one of which is... very colorfully named.
Things I would also like to do before merging this: