Skip to content

fix: windows process spawning #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanamr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: windows process spawning #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f0691
fix: windows process spawning
jordanamr Aug 28, 2025
1a4bf00
use javaw instead of java on windows
jordanamr Aug 28, 2025
f9c200d
fixes
jordanamr Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 24 additions & 15 deletions packages/main/src/modules/GameClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { join } from "path";
import { existsSync, mkdirSync } from "fs";
import { chmodSync } from "fs";
import { stat, chmod, readdir, readFile, appendFile } from "fs/promises";
import { exec } from "child_process";
import { exec, spawn } from "child_process";
import log from "electron-log";
import { GameUpdater, GameSettings, ReplayFile } from "./GameUpdater.js";
import type { AppModule } from "../AppModule.js";
Expand Down Expand Up @@ -240,7 +240,7 @@ export class GameClient implements AppModule {
let javaExecutable: string;
switch (process.platform) {
case "win32":
javaExecutable = join(jreDir, "bin", "java.exe");
javaExecutable = join(jreDir, "bin", "javaw.exe");
break;
case "darwin":
javaExecutable = join(jreDir, "bin", "java.exe");
Expand Down Expand Up @@ -347,20 +347,29 @@ export class GameClient implements AppModule {
cwd: string
): Promise<void> {
return new Promise((resolve, reject) => {
const child = exec(
`"${javaExecutable}" ${args.join(" ")}`,
{ cwd },
(error) => {
if (error && !error.killed) {
log.error("Java process error:", error);
}
}
);
if (child.pid) {
log.info("Launching Java process with executable:", javaExecutable);
log.info("Java arguments:", args);
log.info("Working directory:", cwd);

const child = spawn(javaExecutable, args, {
cwd,
detached: true,
stdio: "ignore",
windowsHide: true, // Hide the console window on Windows
shell: true, // Enable shell parsing for proper quote handling
});

child.on("error", (error) => {
log.error("Failed to start Java process:", error);
reject(new Error(`Failed to start Java process: ${error.message}`));
});

child.on("spawn", () => {
log.info("Java process started successfully with PID:", child.pid);
// Unref the child process so the parent can exit without waiting
child.unref();
resolve();
} else {
reject(new Error("Failed to start Java process"));
}
});
});
}

Expand Down
Loading