fix: repair vpc enis build break from T-1145/T-1294 merge#130
Merged
Conversation
PRs #126 (T-1145, RunE conversion) and #128 (T-1294, writeENIs split) both modified cmd/vpcenis.go and were merged sequentially without rebasing, fusing into code that does not compile: enis() returns error but had a bare 'return', and the void writeENIs() had a stray 'return nil'. Fixes the enis() returns and removes the stray return so main builds again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main HEAD (5f67962) does not compile. PRs #126 (T-1145) and #128 (T-1294) both edited cmd/vpcenis.go and merged sequentially without rebasing, fusing T-1145's
RunEconversion with T-1294's writeENIs split into non-compiling code:enis()returnserrorbut had a barereturnand no trailing returnwriteENIs()had a strayreturn nilThis repairs both.
go build,go test ./...,go vet, and golangci-lint all pass.