Fix tests for Pebble#47
Closed
scx1332 wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the integration test environment to use a pinned local Arkiv node Docker image and adjusts the expected blockNumber returned by a raw query at a specific block.
Changes:
- Pin
golemnetwork/arkiv-op-gethtestcontainer image to a specific tag (instead oflatest). - Update integration test expectation for
rawQueryAtBlock.blockNumberfrom0nto1n.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/src/utils.ts | Pins the Docker image tag used for launching the local Arkiv node in tests. |
| test/src/arkiv.test.ts | Adjusts expected block number for raw query results when atBlock: 1n is used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| export async function launchLocalArkivNode(withFundingAccount: Hex | undefined = undefined) { | ||
| const container = await new GenericContainer("golemnetwork/arkiv-op-geth:latest") | ||
| const container = await new GenericContainer("golemnetwork/arkiv-op-geth:v1.101605.0-2.7-pebble-test") |
Member
Author
|
Of course this won't be merged until we decided to use pebble as main branch |
krzysiekfonal
force-pushed
the
develop
branch
4 times, most recently
from
233c878 to
05c9365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.