Remove dead chains and deprecate kaolin#58
Merged
Conversation
krzysiekfonal
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused/dead chain definitions from the SDK and updates tests accordingly, while keeping kaolin available but explicitly deprecated to signal impending removal.
Changes:
- Removed
mendoza,rosario, andmarketplacechain definitions and stopped exporting them fromsrc/chains. - Updated chain selection usage in the network health integration test to only include supported chains.
- Updated
chainFromNametest coverage to reflect the reduced chain set and validate unknown-chain errors for removed networks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/src/network-health.test.ts | Limits the integration test’s selectable chains to braga and deprecated kaolin. |
| src/utils/chains.test.ts | Removes expectations for deleted chains; asserts removed names now throw as unknown. |
| src/chains/rosario.ts | Removes the Rosario chain definition. |
| src/chains/mendoza.ts | Removes the Mendoza chain definition. |
| src/chains/marketplace.ts | Removes the Marketplace chain definition. |
| src/chains/kaolin.ts | Adds @deprecated JSDoc to the Kaolin chain export with a migration link. |
| src/chains/index.ts | Stops exporting the removed chain modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { defineChain } from "viem" | ||
|
|
||
| /** | ||
| * @deprecated The kaolin network is getting removed on may 15th 2026. Migration guide: https://docs.arkiv.network/networks/migrate-from-kaolin/ |
Comment on lines
+61
to
64
| expect(() => chainFromName("mendoza")).toThrow("Unknown chain: mendoza") | ||
| expect(() => chainFromName("marketplace")).toThrow("Unknown chain: marketplace") | ||
| expect(() => chainFromName("rosario")).toThrow("Unknown chain: rosario") | ||
| expect(() => chainFromName("local")).toThrow("Unknown chain: local") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.