Release to main (remove deleted chains)#60
Closed
SewerynKras wants to merge 3 commits into
Closed
Conversation
Remove dead chains and deprecate kaolin
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes chain definitions that are no longer supported from the SDK’s /chains entrypoint and updates tests to reflect the reduced set of available chains.
Changes:
- Removed the
mendoza,rosario, andmarketplacechain definitions and stopped exporting them from@arkiv-network/sdk/chains. - Updated unit/integration tests to no longer reference the removed chains and to assert they are now treated as unknown.
- Added a
@deprecatedJSDoc annotation tokaolin.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/src/network-health.test.ts | Limits the health-check test’s selectable chains to the remaining supported exports. |
| src/utils/chains.test.ts | Updates chainFromName tests to stop expecting removed chains to resolve and to assert they throw. |
| src/chains/rosario.ts | Deletes the Rosario chain definition. |
| src/chains/mendoza.ts | Deletes the Mendoza chain definition. |
| src/chains/marketplace.ts | Deletes the Marketplace chain definition. |
| src/chains/kaolin.ts | Adds a deprecation notice for Kaolin. |
| src/chains/index.ts | Removes exports for the deleted chains from the public ./chains entrypoint. |
| package.json | Bumps the prerelease version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
64
| expect(() => chainFromName("mendoza")).toThrow("Unknown chain: mendoza") | ||
| expect(() => chainFromName("marketplace")).toThrow("Unknown chain: marketplace") | ||
| expect(() => chainFromName("rosario")).toThrow("Unknown chain: rosario") | ||
| expect(() => chainFromName("local")).toThrow("Unknown chain: local") |
| @@ -1,6 +1,3 @@ | |||
| export { braga } from "./braga" | |||
| export { kaolin } from "./kaolin" | |||
| export { localhost } from "./localhost" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.