Conversation
testdata/flows/multiple.flow is a unit-test scaffolding file without real URLs, producing 0 discovered paths regardless of prefix. No 11 KB real capture is checked into the repo (petstore.flow is generated by the Docker integration tests). Keep the synthetic 80 MB tier as the sole benchmark, which is both reproducible in CI and representative of real-world captures where Python interpreter boot cost no longer dominates the measurement.
Generating the synthetic capture in CI is fragile — it requires httpbin via service container, mitmdump, hey, and Go tooling just to produce a fixture that never changes between runs. Pre-generate once, upload to a GitHub release asset tagged bench-fixtures-v1, download on each CI run with SHA-256 integrity check. The workflow is now ~90 lines shorter and runs in ~3-5 min instead of 10+ min.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the minimal Rust-only benchmark workflow with a comprehensive
Python-vs-Rust comparison. The new workflow generates a synthetic ~80 MB
flow via httpbin + mitmdump + hey, then runs hyperfine and RSS measurements
on both tools against two datasets (Petstore fixture and synthetic). Results
are uploaded as artifacts and optionally auto-committed to
docs/benchmarks.mdon scheduled/manual runs.
Type of Change
Checklist
cargo fmt --allcleancargo clippy --all-targets --all-features -- -D warningscleancargo testpasses locallyCHANGELOG.mdunder[Unreleased](if user-facing)feat:,fix:,docs:, etc.)Testing
Workflow YAML reviewed for correctness. Actual benchmark runs on merge to
main (paths filter matches
.github/workflows/bench.yml). Manual triggeravailable via
workflow_dispatch.Related Issues
Closes #8