Closed#394
Closed
opastorello wants to merge 1 commit into
Closed
Conversation
opastorello
force-pushed
the
security/timing-safe-cron
branch
from
July 16, 2026 15:47
b54838a to
25fb198
Compare
Replaces simple string equality with timingSafeEqual in automations cron endpoint to prevent timing attacks. Mirrors the pattern already used in flows cron (route.ts:42). **Risk**: Theoretical timing attack where an attacker with network access could measure response latency to recover AUTOMATION_CRON_SECRET byte-by-byte. Very low practical risk (cron endpoints not public), but this brings auth consistency across both cron routes. **Changes**: - Import timingSafeEqual from node:crypto - Replace `supplied !== expected` with constant-time comparison - Add comment explaining the defense **Testing**: typecheck + lint clean (0 errors). Refs: SECURITY_AUDIT_2026-07-16.md (finding #2 — LOW severity)
opastorello
force-pushed
the
security/timing-safe-cron
branch
from
July 16, 2026 15:48
25fb198 to
cfca7dd
Compare
opastorello
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed - not needed