feat(webhooks): add secure webhooks engine with rate limiting and configurable integrations#405
Open
DibashSarkar wants to merge 2 commits into
Open
feat(webhooks): add secure webhooks engine with rate limiting and configurable integrations#405DibashSarkar wants to merge 2 commits into
DibashSarkar wants to merge 2 commits into
Conversation
…ture verification, and configurable marketing/prefix options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the core Generic Webhooks engine, allowing external integrations to trigger workflows. Following the previous review, this branch addresses all requested security enhancements, migration ordering, and WhatsApp API routing logic.
Note: This is the final part of splitting up the previous monolithic PR.
Key Changes & Review Feedback Addressed
/marketing_messagesendpoint behind a newuse_marketing_endpointconfig flag on thewhatsapp_configtable (configurable via the UI). It now safely falls back to/messagesfor standard accounts.HMAC Secretto validate incoming requests, preventing unauthorized execution.src/lib/rate-limit.ts) to cap incoming webhooks at 60 requests per minute per workflow, preventing abuse.91country code. The default country code prefix is now fully configurable via the database and Webhooks UI settings.038through041) to start immediately after the latest upstream migrations, preventing any collision with upstream's036.Testing
use_marketing_endpointflag in integration tests.npm run test).npm run typecheck).