Conversation
Replaces Prettier with oxfmt, ESLint with oxlint, and TypeScript 5.7 with the native TypeScript 7 compiler. `oxfmt --migrate=prettier` carried the Prettier config over unchanged, so the formatting rules are identical and only two files reformatted. The `.prettierignore` patterns moved into `.oxfmtrc.json` as `ignorePatterns`, comments and all, and `prettier-ignore.test.ts` follows them there as `format-ignore.test.ts`. `.oxlintrc.json` runs correctness as an error, `typescript/no-explicit-any` as an error, and `--deny-warnings` fails the job on anything else, so the lint job no longer passes with findings. The three findings that surfaced are fixed: an unused import in `DatabaseExplorer`, and an optional chain in `exporter.test.ts` that would have thrown a TypeError rather than failed an assertion. Two `eslint-disable` comments for rules that no longer exist are gone. TypeScript 7 removed `baseUrl`, so `tsconfig.base.json` keeps only `paths`, which resolve relative to the config that declares them. The `typescript` package now ships `tsc` and nothing else; nothing here imports the compiler API. Typecheck drops from 7s to 2s, lint from 7s to 0.4s.
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier → oxfmt, ESLint → oxlint, TypeScript 5.7 → TypeScript 7 (the native
compiler, released as
typescript@7.0.2).Formatting
oxfmt --migrate=prettiercarried.prettierrc.jsonover verbatim — everyoption, including
proseWrap: alwaysandsingleAttributePerLine— so therules are unchanged and oxfmt still covers md/json/css/yaml as well as TS.
Exactly two files reformatted, both a callback-with-object-literal that oxfmt
hugs:
.prettierignorebecameignorePatternsin.oxfmtrc.json(which parsesJSONC, so the friction-log rationale came across intact), and the guard test
that keeps that list honest against
doctor.config.jsonmoved with it:src/prettier-ignore.test.ts→src/format-ignore.test.ts.Linting
.oxlintrc.jsonenables theimport,oxc,typescriptandunicornplugins, runs
correctnessat error, and keepstypescript/no-explicit-anyat error.yarn lintisoxlint --deny-warnings,so the job no longer passes with findings sitting in it — which the old one did.
That meant fixing the three findings first:
DatabaseExplorer.tsx— unuseduseCollectionsimport (ESLint warned aboutthis too, and CI shipped it anyway).
exporter.test.ts—(send.mock.calls[0]?.[0] as unknown[]).lengththrows aTypeError when the call is missing instead of failing the assertion. Replaced
with one
toEqual([100, 50])over the mapped lengths, which also subsumes thetoHaveBeenCalledTimes(2)above it.Two
eslint-disable-next-linecomments naming rules that no longer exist aredeleted; the code lints clean without them.
import/no-unresolvedhas no oxlint equivalent (the resolver handles it) andwas
offanyway, so it is gone rather than ported.TypeScript 7
baseUrlwas removed in 7, sotsconfig.base.jsonkeeps onlypaths, whichnow resolve relative to the config file that declares them — same result here,
since both sit in the repository root.
Worth knowing: the
typescriptpackage now ships thetscbinary and nothingelse — no
tsserver.js, no compiler API. Nothing in this repository imports theAPI, and
@effect/language-serviceis loaded by the editor's own TypeScriptrather than this one, so the editor is unaffected unless it is explicitly
pointed at the workspace TypeScript. Noted in
CLAUDE.md.Verification
typecheck,lint,format:check,test(1607/1607),packageandfallowall pass locally.
yarn typecheckyarn lintyarn format:checkyarn.lockloses ~1500 lines.Follow-up
oxlint's type-aware rules (
no-floating-promisesand friends) needoxlint-tsgolint;todo.mdnow tracks that in place of the "upgrade the lintstack" item this closes.
🤖 Generated with Claude Code
https://claude.ai/code/session_0156WamccrozzRDnhxs9nRH7