Implement LDAP-authenticated AD object query function#236
Merged
Conversation
|
PSScriptAnalyzer results: Errors: [0], Warnings: [14], Information: [0]
|
…sposal and DN construction Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement function to extract information from Active Directory via LDAP
Implement LDAP-authenticated AD object query function
Feb 27, 2026
|
PSScriptAnalyzer results: Errors: [0], Warnings: [14], Information: [0]
|
rebelinux
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get-ADObjectListlacked aCredentialparameter and only applied credentials when$Serverwas provided, making authenticated LDAP queries unreliable. Several additional bugs were present in resource management and list initialization.Changes
[pscredential]$Credentialparameter; credentials now passed toDirectoryEntryin all code paths (with and without-Server)$results.Dispose()and$directoryEntry.Dispose()to prevent leaks fromSearchResultCollectionandDirectoryEntry[System.Collections.Generic.List[PSObject]]$x = [System.Collections.ArrayList]::new()→[System.Collections.Generic.List[PSObject]]::new()($Domain.Split('.') | ForEach-Object { "DC=$_" }) -join ','-Objectis omitted now uses(objectClass=*)instead of throwing a null-reference on$filters[0][CmdletBinding()],[OutputType([System.Collections.Generic.List[PSObject]])], and a proper comment-based help blockExample usage
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.