fix(network): add timeout to prevent app freeze on slow network - #5
Open
MedCy1 wants to merge 1 commit into
Open
fix(network): add timeout to prevent app freeze on slow network#5MedCy1 wants to merge 1 commit into
MedCy1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add network timeouts to prevent app freeze
What does this PR do?
This PR adds a 5-second timeout to the network requests used for fetching the application logo and the version information in
ui/main_window.py.Why is this change necessary?
By default, the Python
requestslibrary has no timeout. If the user has a slow internet connection, or if the remote server hangs/drops packets, the installer could freeze indefinitely (blocking the UI) while waiting for a response.Adding a specific timeout ensures the application fails gracefully (and continues loading) rather than hanging completely during startup.
Key Changes:
timeout=5parameter to therequests.get()call for the remote logo URL.timeout=5parameter to therequests.get()call for the Ascendara API version check.How to test:
python app.py).