perf(ui): optimize animation thread to only run when needed - #6
Open
MedCy1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perf: Optimize animation loop to reduce CPU usage
What does this PR do?
This PR optimizes the background animation thread used for the progress bar. Instead of running a continuous 60 FPS loop even when idle, the thread now uses a
threading.Eventto sleep (block) until animation is explicitly required.Why is this change necessary?
Previously, the
_animation_loopwas running constantly from the moment the application started, consuming unnecessary CPU cycles even when no installation was happening.This change ensures the animation thread is dormant (0% CPU usage) until the "indeterminate" progress mode is active, and wakes up only when needed.
Key Changes:
threading.Event(self._animation_event) to control the animation thread._animation_loopnow waits for the event signal before calculating frames.try/exceptblock in_update_animation_frameto prevent errors if the widget is destroyed during updates.close()method to properly signal the thread to exit, ensuring no zombie threads remain after closing the app.How to test:
python app.py).