refactor(ui): merge duplicate status update functions - #7
Open
MedCy1 wants to merge 1 commit into
Open
Conversation
Author
|
Calling it a night after little 6 PRs! Apologies to the maintainers' notification bells... I promise I'm done spamming for today. 😅 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor(ui): Unify status update logic and remove redundant code
What does this PR do?
This PR simplifies how status updates are handled in the UI by consolidating logic into a single method and removing redundant code.
Key Changes:
_update_statusto update all relevant UI labels (status_label,status_text, andcurrent_task) simultaneously.InstallerProcesscallback to use the main_update_statusmethod instead of the specific helper._update_status_textmethod as it is no longer needed (logic is now handled by_update_status).Why is this change necessary?
Previously, there were two different methods handling status updates (
_update_statusand_update_status_text), which led to code duplication and potential inconsistencies in the UI (e.g., the "Current Task" label might not match the logs).This change ensures that every status update is consistently reflected across all UI elements and keeps the codebase cleaner (DRY principle).
How to test:
python app.py).