Skip to content

Handle Chrome bookmarks API failures safely#138

Merged
AshutoshDash1999 merged 1 commit into
AshutoshDash1999:masterfrom
rudra-chothe:fix/bookmarks-api-error-recovery
Jun 21, 2026
Merged

Handle Chrome bookmarks API failures safely#138
AshutoshDash1999 merged 1 commit into
AshutoshDash1999:masterfrom
rudra-chothe:fix/bookmarks-api-error-recovery

Conversation

@rudra-chothe

Copy link
Copy Markdown
Contributor

Summary

  • Fixed browser bookmark loading so Chrome bookmarks API failures are handled safely.
  • Prevented the bookmarks section from getting stuck in loading when chrome.bookmarks is unavailable or rejects.
  • Added fallback/error handling in the bookmark hook and surfaced a safe UI fallback state in the bookmarks section.

Closes #123

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor (no behavior change)
  • Chore / tooling
  • UI polish

Screenshots / Screen Recording

N/A

How to Test

  1. Run npm run dev (or build/load extension as needed).
  2. Open the dashboard and verify bookmarks load normally in a valid extension context.
  3. Trigger a failing/unavailable chrome.bookmarks scenario (e.g., missing permission/unavailable runtime context).
  4. Open the bookmarks section and confirm:
    • loading stops,
    • fallback/error state is shown,
    • dashboard remains usable.
  5. Verify quality checks:
    • npm run lint
    • npm run typecheck
    • npm run build

Checklist

  • I linked the related issue, if one exists.
  • I assigned myself before opening the PR, if required.
  • npm run lint passes.
  • npm run typecheck passes.
  • npm run build succeeds.
  • I reviewed my own changes before requesting review.
  • I did not change unrelated files.
  • I updated documentation if needed.

@AshutoshDash1999 AshutoshDash1999 merged commit 1adc8f3 into AshutoshDash1999:master Jun 21, 2026
5 checks passed
@AshutoshDash1999 AshutoshDash1999 added bug Something isn't working level:intermediate Intermediate level PR gssoc:approved labels Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc:approved level:intermediate Intermediate level PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Browser bookmarks section can remain stuck in loading state when Chrome bookmarks API fails

2 participants