feat(node-registry): persist interview capabilities (schema v5)#227
Merged
Conversation
Record the remaining post-inclusion interview data into each node's row so capabilities survive restarts and are queryable without re-interviewing (part of #203). Builds on the schema-v4 device-identity persistence. - NodeInfo gains the Version (CC 0x86) triple (library/protocol/application versions), the Multi Channel (CC 0x60) endpoint summary (count + dynamic/ identical flags), and the Z-Wave Plus (CC 0x5E) role/node-type/icon info. - NodeRegistry subscribes to NodeVersionReport / MultiChannelEndPointReport / ZWavePlusInfoReport and calls the new setVersionInfo / setEndpointInfo / setZWavePlusInfo, each updating the in-memory entry and persisting it (no-op for unknown nodes, mirroring setDeviceIdentity). - Schema v5: 13 capability columns, cumulative migration from v1/v2/v3/v4 (v4 keeps its identity triple; v0 still drops + recreates). - Tests: set/query per report, unknown-node no-op, and report-driven recording across all three reports. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persists the remaining post-inclusion interview data into each node's
NodeRegistryrow, so capabilities survive daemon restarts and are queryable without re-interviewing. Builds directly on the schema-v4 device-identity persistence (#226). Part of #203.Changes
NodeInfogains:libraryType/protocolVersion/protocolSubVersion/applicationVersion/applicationSubVersion.endpointCount+endpointsDynamic/endpointsIdenticalflags.zwavePlusVersion/roleType/nodeType/installerIconType/userIconType.NodeRegistrysubscribes toNodeVersionReport/MultiChannelEndPointReport/ZWavePlusInfoReportand calls the newsetVersionInfo/setEndpointInfo/setZWavePlusInfo, each updating the in-memory entry and persisting it (no-op for unknown nodes, mirroringsetDeviceIdentity).Scope note
Persistence only — exposing these over
GetNodes/ the console detail pane (#45) remains a separate follow-up.Tests
tests/node_registry_capabilities_test.cpp: set/query for each report, unknown-node no-op, and report-driven recording across all three reports. Full suite: 482/482 pass on bothgnuandllvm; clang-tidy + clang-format clean.🤖 Generated with Claude Code