Short-circuit update.sh when a pull finds nothing new#15
Merged
Conversation
Tracked NEEDS_REBUILD in the Sync phase: a fast-forward pull that leaves HEAD unchanged sets it to 0, and the script then exits before Build/Shims/Hooks with "Already up to date, nothing to rebuild" instead of redoing identical work and falsely reporting "updated". --dev and a dirty/diverged checkout still rebuild (NEEDS_REBUILD stays 1), and a new --force/-f flag forces the full run for repair cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to v0.72.
update.shpreviously always ran Build + Shims + Hooks and printed "Expediter updated!" even whengit pullfound nothing new, which is wasted work and a misleading message.This tracks
NEEDS_REBUILDin the Sync phase: a fast-forward pull that leaves HEAD unchanged sets it to 0, and the script exits early with "Already up to date, nothing to rebuild." A pulled change, a--dev/--no-pullrun, or a dirty/diverged checkout still rebuilds. New--force/-fforces the full run for repair cases.No user-facing behavior change beyond the update flow itself; UI version stays v0.72.