Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Argent Hero ability ("argentHeroStep4") to properly retain all unit states—including galvanize—when moving units. Previously, the code only manually handled damage state transfer (removing/adding damaged flags) and completely ignored the galvanize state. The new approach leverages the existing RemovedUnit state-tracking infrastructure used by RemoveUnitService and AddUnitService to preserve all unit states during the move.
Changes:
- Replaced manual damage-state handling in
argentHeroStep4with state-preservingremoveUnits/addUnitsoverloads that track and restore all unit states (damage + galvanize). - Removed the block of code that manually transferred damage between origin and destination unit holders.
- Simplified the method by ~12 lines while gaining broader state preservation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.