This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Conversation
This was done by running the `cargo fmt` command on the crate.
Owner
|
This looks fine to me (but it is a lot of code to check over). It looks like the library may be getting some actual maintenance soon ( #199 ) so if that involves some refactor I'll leave it up to those parties to decide whether these formatting improvements should come before or after. |
Author
|
Thanks for the reply! The format PR was in fact a prerequisite for more refactorings that I would like to send to you soon, if there is interest. I think you should check the code, or run the same command yourself and check there are no extraneous diffs, it should be a quick one. Anyway let me know what you prefer, I would like it for rusty-machine to become the de facto ML crate in Rust! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done by running the
cargo fmtcommand on the crate.