Fix dashboard-only permission leaking global extract access#2
Open
AtlasLabs797 wants to merge 1 commit intomainfrom
Open
Fix dashboard-only permission leaking global extract access#2AtlasLabs797 wants to merge 1 commit intomainfrom
AtlasLabs797 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PuedeVerDashboard=truewas being treated as full data access inExtractosController, allowing non-admin users with dashboard-only permissions to read extractos across all cuentas and creating a cross-account data exposure that conflicts withUserAccessServicesemantics.Description
p.PuedeVerDashboardfrom the global-access condition inGetAllowedAccountIdsand the identical check inCanViewTitularwithinAtlas Balance/backend/src/GestionCaja.API/Controllers/ExtractosController.csso global access now requires one ofPuedeAgregarLineas,PuedeEditarLineas,PuedeEliminarLineasorPuedeImportar.Documentacion/DOCUMENTACION_CAMBIOS.mdandDocumentacion/LOG_ERRORES_INCIDENCIAS.mdto record the fix and associated it with versionV-01.02.CuentaId/TitularIdpermission handling.Testing
sed -n,git diffand file inspection to confirm the condition was updated and documentation entries were added, and committed the change.dotnetbuild ordotnet testin this environment becausedotnetis not available (command not found), so runningdotnet test "Atlas Balance/backend/GestionCaja.sln" -c Releasein an environment with the .NET SDK is pending.Codex Task