Publicar V-01.04#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ad0b10294
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (request.NuevaFechaVencimiento < request.NuevaFechaInicio) | ||
| { | ||
| throw new InvalidOperationException("La fecha de vencimiento no puede ser anterior a la fecha de inicio"); |
There was a problem hiding this comment.
RenovarAsync only checks that NuevaFechaVencimiento is not earlier than NuevaFechaInicio, but it never validates that the client actually sent real dates. With ASP.NET model binding, a payload like {} (or missing date fields) binds both DateOnly values to 0001-01-01, passes this check, and then overwrites the plazo fijo with year-1 dates. That silently corrupts maturity data and can immediately force incorrect vencido status in later jobs.
Useful? React with 👍 / 👎.
| if (tipoTitular.HasValue) | ||
| { | ||
| query = query.Where(c => _dbContext.Titulares.Any(t => t.Id == c.TitularId && t.Tipo == tipoTitular.Value)); |
There was a problem hiding this comment.
When incluirEliminados=true, the cuentas query correctly switches to Cuentas.IgnoreQueryFilters(), but the new tipoTitular predicate still queries _dbContext.Titulares with its default soft-delete filter. This means cuentas tied to soft-deleted titulares are incorrectly excluded whenever tipoTitular is used, so admin users cannot retrieve the full deleted dataset despite explicitly requesting it.
Useful? React with 👍 / 👎.
1 participant
No description provided.