Skip to content

DLC close messagetype#122

Merged
dillionverma merged 6 commits intomasterfrom
dlc-close
Aug 11, 2021
Merged

DLC close messagetype#122
dillionverma merged 6 commits intomasterfrom
dlc-close

Conversation

@dillionverma
Copy link
Copy Markdown
Collaborator

@dillionverma dillionverma commented Aug 10, 2021

Implementation of DLC close based on discussion in specs.

discreetlogcontracts/dlcspecs#161
discreetlogcontracts/dlcspecs#170

Comment thread packages/messaging/lib/MessageType.ts Outdated

DlcCancelV0 = 52172,

DlcCloseV0 = 11111, // TODO
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some ongoing but un-decided discussion here
https://github.com/discreetlogcontracts/dlcspecs/pull/170/files#r674408145

@dillionverma dillionverma changed the title Dlc close messagetype DLC close messagetype Aug 11, 2021
@dillionverma dillionverma marked this pull request as ready for review August 11, 2021 14:48
Comment thread packages/messaging/lib/messages/DlcClose.ts Outdated
Copy link
Copy Markdown
Collaborator

@zpv zpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants