Skip to content

Remove oauth#146

Merged
Heliophist merged 8 commits intomainfrom
remove-oauth
May 5, 2026
Merged

Remove oauth#146
Heliophist merged 8 commits intomainfrom
remove-oauth

Conversation

@Pramad712
Copy link
Copy Markdown
Contributor

@Pramad712 Pramad712 commented May 5, 2026

  1. Remove ALL Authentication / OAuth
  2. Update UploadButton to let the user upload the file from their system but upload it to the google drive of an external gmail (in .env)
  3. Add an Email field to the google forms to still let them be collection
  4. Improve phone number validation
  5. Remove checkmarks for events that are already signed up for (users can sign up multiple times)
  • Android Testing
  • iOS Testing

Pramad712 and others added 3 commits May 2, 2026 12:47
Copilot AI review requested due to automatic review settings May 5, 2026 03:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🚀 Expo preview is ready!

  • Project → audacity-music-club
  • Platforms → android, ios
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the app’s end-user OAuth sign-in flow (Google/Apple) and associated screens/dependencies, shifting the app toward a “no login” experience while still supporting Google Drive uploads and adding email collection to several forms.

Changes:

  • Removed Google/Apple sign-in screens and dependencies; app now always starts on Home.
  • Updated form submission tracking to use a local identifier ("local") instead of a stored user object.
  • Added email fields (and corresponding Google Form entry IDs) to multiple volunteer/request forms and wired up “Request a Concert” into the form picker.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/utils/index.js Removes getUser utility; leaves general shared utilities.
src/utils/forms/RequestConcert.js Adds an email question/state to the Request Concert form.
src/utils/forms/LibraryMusicHour.js Removes user-prefill logic; adds email question/state; updates UploadButton usage.
src/utils/forms/Form.js Stops using user ID for submission hashing; uses "local" for per-device tracking.
src/utils/forms/DanceClub.js Removes user-prefill logic; adds email question/state.
src/screens/VolunteerFormScreen.js Adds RequestConcert to form selection; fixes submit flow duplication.
src/screens/SignInScreen.js Deleted (OAuth sign-in removed).
src/screens/HomeScreen.js Removes user lookup; uses "local" in hash generation.
src/screens/AccountScreen.js Deleted (account/logout management removed).
src/constants/formIDs.js Adds email entry IDs to multiple forms.
src/components/UploadButton.js Reworks upload auth to mint Drive tokens via refresh token; removes navigation dependency; improves UX messaging.
src/components/Profile.js Deleted (was tied to stored user profile).
src/components/HomeHeader.js Removes profile/account navigation UI; simplifies header.
package.json Removes Google Sign-In and Apple auth dependencies.
package-lock.json Removes corresponding locked dependencies.
App.js Removes auth gating and Sign In/Account screens; initial route always Home.
app.config.js Removes Apple Sign-In usage/plugin config; sources support email from env var.
Comments suppressed due to low confidence (1)

app.config.js:33

  • extra.email is now sourced from process.env.EXPO_PUBLIC_EMAIL without a fallback or validation. If the env var is missing in a build, user-facing strings (e.g., error prompts and the feedback mailto link) will include undefined and produce a broken mailto URL. Consider providing a default value and/or throwing/logging when the env var is absent.
  extra: {
    email: process.env.EXPO_PUBLIC_EMAIL,
    eas: {
      projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
    },
  },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/UploadButton.js
Comment thread src/components/UploadButton.js Outdated
Comment thread src/components/UploadButton.js Outdated
Comment thread src/components/UploadButton.js
Comment thread src/utils/index.js
Comment thread App.js
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

app.config.js:33

  • extra.email is now sourced directly from process.env.EXPO_PUBLIC_EMAIL with no fallback. If the env var is missing in a build, user-facing error dialogs will show an undefined email address (see alertError). Consider providing a default value or throwing/logging loudly when the env var is unset.
    favicon: "./src/assets/eternity-band.png",
  },
  extra: {
    email: process.env.EXPO_PUBLIC_EMAIL,
    eas: {
      projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
    },
  },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/UploadButton.js
Comment thread src/components/UploadButton.js Outdated
Comment thread src/utils/forms/RequestConcert.js Outdated
Comment thread src/utils/forms/LibraryMusicHour.js Outdated
Comment thread src/utils/forms/DanceClub.js Outdated
Comment thread src/screens/HomeScreen.js
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

app.config.js:33

  • extra.email is now populated directly from process.env.EXPO_PUBLIC_EMAIL with no fallback/validation. If that env var isn’t set at build time, Constants.expoConfig.extra.email will be undefined and user-facing error messages will show an invalid contact address. Consider providing a default, or throwing/logging clearly when the env var is missing (similar to how other EXPO_PUBLIC_* vars are handled elsewhere).
  extra: {
    email: process.env.EXPO_PUBLIC_EMAIL,
    eas: {
      projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
    },
  },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/UploadButton.js
Comment thread src/components/UploadButton.js
Comment thread src/utils/index.js Outdated
Comment thread src/components/VolunteerOpportunity.js Outdated
Comment thread src/components/HomeHeader.js
Comment thread package.json
Comment thread App.js
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

app.config.js:33

  • extra.email is now set directly from process.env.EXPO_PUBLIC_EMAIL with no fallback or validation. If the env var is unset in a build, user-facing UI (mailto links / error alerts) will show "undefined". Consider providing a safe default (e.g., the previous address) or failing fast with a clear build-time/runtime error when missing.
  extra: {
    email: process.env.EXPO_PUBLIC_EMAIL,
    eas: {
      projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
    },
  },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/UploadButton.js
Comment thread src/screens/HomeScreen.js
@Heliophist Heliophist self-requested a review May 5, 2026 04:48
Copy link
Copy Markdown
Contributor

@Heliophist Heliophist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Heliophist Heliophist merged commit 4dd52a9 into main May 5, 2026
5 checks passed
@Pramad712 Pramad712 deleted the remove-oauth branch May 9, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants