Remove oauth#146
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
🚀 Expo preview is ready!
|
There was a problem hiding this comment.
Pull request overview
This PR removes the app’s end-user OAuth sign-in flow (Google/Apple) and associated screens/dependencies, shifting the app toward a “no login” experience while still supporting Google Drive uploads and adding email collection to several forms.
Changes:
- Removed Google/Apple sign-in screens and dependencies; app now always starts on
Home. - Updated form submission tracking to use a local identifier (
"local") instead of a stored user object. - Added
emailfields (and corresponding Google Form entry IDs) to multiple volunteer/request forms and wired up “Request a Concert” into the form picker.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/index.js | Removes getUser utility; leaves general shared utilities. |
| src/utils/forms/RequestConcert.js | Adds an email question/state to the Request Concert form. |
| src/utils/forms/LibraryMusicHour.js | Removes user-prefill logic; adds email question/state; updates UploadButton usage. |
| src/utils/forms/Form.js | Stops using user ID for submission hashing; uses "local" for per-device tracking. |
| src/utils/forms/DanceClub.js | Removes user-prefill logic; adds email question/state. |
| src/screens/VolunteerFormScreen.js | Adds RequestConcert to form selection; fixes submit flow duplication. |
| src/screens/SignInScreen.js | Deleted (OAuth sign-in removed). |
| src/screens/HomeScreen.js | Removes user lookup; uses "local" in hash generation. |
| src/screens/AccountScreen.js | Deleted (account/logout management removed). |
| src/constants/formIDs.js | Adds email entry IDs to multiple forms. |
| src/components/UploadButton.js | Reworks upload auth to mint Drive tokens via refresh token; removes navigation dependency; improves UX messaging. |
| src/components/Profile.js | Deleted (was tied to stored user profile). |
| src/components/HomeHeader.js | Removes profile/account navigation UI; simplifies header. |
| package.json | Removes Google Sign-In and Apple auth dependencies. |
| package-lock.json | Removes corresponding locked dependencies. |
| App.js | Removes auth gating and Sign In/Account screens; initial route always Home. |
| app.config.js | Removes Apple Sign-In usage/plugin config; sources support email from env var. |
Comments suppressed due to low confidence (1)
app.config.js:33
- extra.email is now sourced from process.env.EXPO_PUBLIC_EMAIL without a fallback or validation. If the env var is missing in a build, user-facing strings (e.g., error prompts and the feedback mailto link) will include
undefinedand produce a broken mailto URL. Consider providing a default value and/or throwing/logging when the env var is absent.
extra: {
email: process.env.EXPO_PUBLIC_EMAIL,
eas: {
projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
},
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
app.config.js:33
extra.emailis now sourced directly fromprocess.env.EXPO_PUBLIC_EMAILwith no fallback. If the env var is missing in a build, user-facing error dialogs will show an undefined email address (seealertError). Consider providing a default value or throwing/logging loudly when the env var is unset.
favicon: "./src/assets/eternity-band.png",
},
extra: {
email: process.env.EXPO_PUBLIC_EMAIL,
eas: {
projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
},
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
app.config.js:33
extra.emailis now populated directly fromprocess.env.EXPO_PUBLIC_EMAILwith no fallback/validation. If that env var isn’t set at build time,Constants.expoConfig.extra.emailwill beundefinedand user-facing error messages will show an invalid contact address. Consider providing a default, or throwing/logging clearly when the env var is missing (similar to how other EXPO_PUBLIC_* vars are handled elsewhere).
extra: {
email: process.env.EXPO_PUBLIC_EMAIL,
eas: {
projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
},
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
app.config.js:33
extra.emailis now set directly fromprocess.env.EXPO_PUBLIC_EMAILwith no fallback or validation. If the env var is unset in a build, user-facing UI (mailto links / error alerts) will show "undefined". Consider providing a safe default (e.g., the previous address) or failing fast with a clear build-time/runtime error when missing.
extra: {
email: process.env.EXPO_PUBLIC_EMAIL,
eas: {
projectId: "56bb99cb-9cbe-423d-9a88-3f82a0cf3aa0",
},
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.