feat: refactor finalizeUpload with options object and extraction helpers - #582
Merged
Akatenvictor merged 4 commits intoSep 1, 2026
Conversation
|
@luciusverus-cyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
… pattern Extracts S3 upload, DB persistence, chunk merging, and queue submission into separate functions. Reduces finalizeUpload from 9 parameters to 1 options object plus context. Drops function length below threshold while maintaining all existing tests. Closes AudioBitsStellar#304
Extracts mergeChunks, uploadToS3, persistSongRecord, and submitToProcessingQueue as focused helpers. Adds validateChunks, calculateRetryDelay, and withRetry utility functions. Reduces finalizeUpload from 9 params to 1 options object. Closes AudioBitsStellar#304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors finalizeUpload in SongService.ts to reduce parameter count and function length per acceptance criteria.
Closes #304