fix: scroll restoration, autoplay resume, and track-list memoization (#131 #134 #161) - #377
Open
nekwasar wants to merge 1 commit into
Open
fix: scroll restoration, autoplay resume, and track-list memoization (#131 #134 #161)#377nekwasar wants to merge 1 commit into
nekwasar wants to merge 1 commit into
Conversation
…udioBitsStellar#131 AudioBitsStellar#134 AudioBitsStellar#161) - AudioBitsStellar#131: clear saved scroll position on fresh navigation (only restore on back/forward); add scroll restoration to the marketplace (explore) page - AudioBitsStellar#134: resume the AudioContext on the user gesture that unblocks autoplay; gate the 'click to play' banner to once per session - AudioBitsStellar#161: memoize virtualized TrackList rows and stabilize the play callback so list re-renders do not cascade into every visible row
|
Someone is attempting to deploy a commit to the akatenvictor's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131, Closes #134, Closes #161
Implements the remaining acceptance-criteria gaps for these three issues on top of the existing fixes already on main:
#131 — Scroll restoration
#134 — Autoplay policy
AudioContexton the exact user gesture that unblocks autoplay (asuspendedcontext only starts after a user interaction, so the resume must happen inside the click/keydown handler).#161 — Re-renders
TrackListrow and stabilize the per-track play callback so list re-renders no longer cascade into every visible row.Verification
tsc --noEmitpasses (excluding pre-existing upstream failures: missingnext-env.d.tsPNG declarations and a missingTransactionTablecomponent).vitestpasses for the affected suites: useScrollRestoration (4), PlaybackContext (45), PlayerAudioFeatures (7).eslintclean on all touched files.