Fix "continue anyway" on banned group detection

[mrz948]

Previously this did the opposite, aka. if a user typed "y", the check for the tracker failed, if they type "n", the upload would continue.

Summary by CodeRabbit

• Bug Fixes
  • Fixed confirmation prompt behavior when encountering banned group warnings, allowing users to correctly proceed or abort as intended.

[github-actions]

Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time.

If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion.

If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed.

If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base.

Details for the new code base will follow at a later date.

[coderabbitai]

📝 Walkthrough

Walkthrough

The check_banned_group function in src/trackersetup.py inverts its condition logic for user confirmation prompts. Previously, the function returned False when the user answered "yes" to continue; it now only returns False when the user confirms continuation, reversing the control flow behavior.

Changes

Cohort / File(s)	Summary
Control Flow Inversion src/trackersetup.py	Inverted conditional logic in check_banned_group user prompt handling; the response to "Do you want to continue anyway?" now triggers opposite behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A question flipped, a yes becomes no,
Through logic gates the logic must flow,
One line of code, inverted and true,
Now the path branches quite differently through! 🔄

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the specific fix being applied: correcting the 'continue anyway' behavior on banned group detection, which directly matches the main change in the PR.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}