Skip to content

fix: username validation requirements (AAI-757)#191

Open
marius-mather wants to merge 4 commits intomainfrom
fix/username-validation
Open

fix: username validation requirements (AAI-757)#191
marius-mather wants to merge 4 commits intomainfrom
fix/username-validation

Conversation

@marius-mather
Copy link
Collaborator

@marius-mather marius-mather commented Mar 4, 2026

Description

AAI-757: make sure username validation is in sync with https://biocloud.atlassian.net/browse/AAI-559

Changes

  • Update username validation schema and error message
  • Add test cases for valid/invalid usernames

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

Run uv run pytest

Copy link
Contributor

@amandazhuyilan amandazhuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few english words picking

marius-mather and others added 2 commits March 4, 2026 15:19
Co-authored-by: Amanda Zhu <amandazhuyilan@gmail.com>
Co-authored-by: Amanda Zhu <amandazhuyilan@gmail.com>
Copy link
Contributor

@amandazhuyilan amandazhuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants