remove add button for tags addition - #664
Merged
Merged
Conversation
Contributor
Author
I am not sure if we want to keep this "add" button on information panel. |
Contributor
|
Functionality is looking good! We'll discuss at meeting whether to keep or not. I lean towards keep but I could see otherwise. Once we decide, will approve PR! |
rhit-yuw2
marked this pull request as draft
March 27, 2026 18:01
rhit-yuw2
marked this pull request as ready for review
April 3, 2026 00:13
helena-donaldson
requested changes
Apr 3, 2026
helena-donaldson
left a comment
helena-donaldson
left a comment
Contributor
There was a problem hiding this comment.
Console errors regarding need for unique key prop occur whenever adding tag.
If we're keeping it so that tags are always deletable, the deletable prop on the Tag component could be removed.
Contributor
|
Forgot, sorry- how did the Experiment in Queue turn blue? |
helena-donaldson
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.