Skip to content

Enable SwiftLint rule: unneeded_parentheses_in_closure_argument #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mokagio wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Enable SwiftLint rule: unneeded_parentheses_in_closure_argument #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ only_rules:
# Lines should not have trailing whitespace.
- trailing_whitespace

# Closure arguments should not be wrapped in parentheses.
- unneeded_parentheses_in_closure_argument

- custom_rules

# Rules configuration
Expand Down
2 changes: 1 addition & 1 deletion Sources/Encrypted Logs/LogEncryptor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class LogEncryptor {
""".data(using: .utf8)!)

/// Use the `next:` label because of https://bugs.swift.org/browse/SR-1582
try inputFileHandle.readChunkedDataToEndOfFile(next: { (data) in
try inputFileHandle.readChunkedDataToEndOfFile(next: { data in
guard let message = stream_enc.push(message: Bytes(data)) else { // encrypt the data
throw LogEncryptorError.unableToEncryptFile
}
Expand Down
6 changes: 3 additions & 3 deletions Tests/Tests/Event Logging/EventLoggingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class EventLoggingTests: XCTestCase {
let uploadCount = Int.random(in: 3...10)
var isUploading = false

waitForExpectation() { (exp) in
waitForExpectation() { exp in
exp.expectedFulfillmentCount = uploadCount

let eventLogging = self.eventLogging(delegate: MockEventLoggingDelegate()
Expand Down Expand Up @@ -47,7 +47,7 @@ class EventLoggingTests: XCTestCase {
let uploadCount = Int.random(in: 3...10)
let logs = (0...uploadCount).map { _ in LogFile.containingRandomString() }

try waitForExpectation() { (exp) in
try waitForExpectation() { exp in
exp.expectedFulfillmentCount = logs.count

let delegate = MockEventLoggingDelegate()
Expand All @@ -70,7 +70,7 @@ class EventLoggingTests: XCTestCase {

let uploadCount = Int.random(in: 3...10)

waitForExpectation() { (exp) in
waitForExpectation() { exp in
exp.expectedFulfillmentCount = 1
exp.assertForOverFulfill = true

Expand Down