Fix likes and reposts showing in standard Comments block when other plugins also filter comment types#2981
Draft
Fix likes and reposts showing in standard Comments block when other plugins also filter comment types#2981
Conversation
… plugin also excludes comment types. When a plugin like Friends or Webmention set type__not_in on the comment query via pre_get_comments, ActivityPub silently skipped adding its own exclusions. Merge the ActivityPub comment types with any existing type__not_in values instead of bailing out. Fixes #2747
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2747
Proposed changes:
When another plugin (e.g. Friends, Webmention, Event Bridge) registers a pre_get_comments callback that sets type__not_in, ActivityPub was silently skipping its own exclusion of likes, reposts, and quote comment types. This caused those interactions to appear in the standard WordPress Comments block even when the Fediverse Reactions block was also present on the page.
The fix merges ActivityPub's comment type exclusions with any existing type__not_in values instead of bailing out early when type__not_in is already set.
Other information:
Testing instructions:
Changelog entry
Significance: Patch, Type: Fixed
Fix likes and reposts appearing in the standard Comments block when another plugin also filters comment types.