configure.ac: fix __progname check with gcc >= 14#9
Open
ffontaine wants to merge 1 commit into
Open
Conversation
Include stdio.h to avoid that __progname check wrongly returns that the function is unavailable with gcc >= 14 which enables -Werror=implicit-function-declaration (https://gcc.gnu.org/gcc-14/porting_to.html): configure:5231: checking if libc defines __progname configure:5249: /home/autobuild/autobuild/instance-7/output-1/host/bin/sh4-buildroot-linux-musl-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -static -Wall -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c >&5 conftest.c: In function 'main': conftest.c:73:27: error: implicit declaration of function 'printf' [-Wimplicit-function-declaration] 73 | extern char *__progname; printf("%s", __progname); | ^~~~~~ conftest.c:1:1: note: include '<stdio.h>' or provide a declaration of 'printf' 1 | /* confdefs.h */ conftest.c:73:27: warning: incompatible implicit declaration of built-in function 'printf' [-Wbuiltin-declaration-mismatch] 73 | extern char *__progname; printf("%s", __progname); | ^~~~~~ conftest.c:73:27: note: include '<stdio.h>' or provide a declaration of 'printf' resulting in the following static build failure: /home/autobuild/autobuild/instance-7/output-1/host/lib/gcc/sh4-buildroot-linux-musl/14.1.0/../../../../sh4-buildroot-linux-musl/bin/ld: /home/autobuild/autobuild/instance-7/output-1/host/sh4-buildroot-linux-musl/sysroot/lib/libc.a(libc.o):(.bss.__progname+0x0): multiple definition of `__progname'; autossh.o:(.bss+0x120): first defined here Fixes: - http://autobuild.buildroot.org/results/5d80a8096d0f5529cbd86903a74f3bab3d230f4a Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
dmikushin
added a commit
to dmikushin/autossh-1.4g
that referenced
this pull request
Apr 29, 2026
Reviewer noted the well-known surprise of 'set -e' interacting with 'if "$@"; then' dispatch in run_it_test — set -e semantics inside a function called as an if condition are shell-dependent and easy to get wrong. We never relied on set -e: every test function already does explicit '|| return 1' and 'return 1' after error checks. Removing set -e and adding a comment about why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
stdio.hto avoid that__prognamecheck wrongly returns that the function is unavailable with gcc >= 14 which enables-Werror=implicit-function-declaration(https://gcc.gnu.org/gcc-14/porting_to.html):resulting in the following static build failure:
Fixes: