Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions tests/e2e/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"private": true,
"devDependencies": {
"@axe-core/playwright": "4.12.1",
"@playwright/test": "1.61.1"
"@playwright/test": "1.62.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 End-to-end tests break because the test browser image was not upgraded alongside the test tool

The end-to-end test tool is upgraded to a new version (@playwright/test "1.62.0" at tests/e2e/package.json:6) without upgrading the pinned browser image it runs inside, so the browsers bundled in the container no longer match the tool and the tests fail to launch a browser.

Impact: The end-to-end test tier fails in CI (and in the local container), blocking the build even though nothing in the app changed.

Version pin mismatch between npm package and Playwright Docker image

The e2e suite runs inside the pinned image mcr.microsoft.com/playwright:v1.61.1-noble (.devcontainer/Dockerfile:3, also referenced in tests/README.md:29 and CLAUDE.md:91), which ships browser builds matching Playwright 1.61.1. The Makefile target only runs npm ci then npx playwright test (Makefile:27-28, Makefile:46-47) and never runs npx playwright install, so no 1.62.0 browsers are downloaded. Playwright validates that installed browser revisions match the package version; with @playwright/test at 1.62.0 the expected browser revisions differ from those baked into the 1.61.1 image, causing browserType.launch: Executable doesn't exist failures. Per CLAUDE.md, CI runs make test inside this exact image, so a green run requires the image tag and npm package version to be bumped together (the same class of coupled-bump issue documented for vite/vitest). The Docker image tag in .devcontainer/Dockerfile and the references in tests/README.md/CLAUDE.md must be bumped to v1.62.0-noble in the same change.

Prompt for agents
Bumping @playwright/test to 1.62.0 in tests/e2e/package.json changes the browser revisions Playwright expects at runtime. The e2e tests run inside the pinned Docker image mcr.microsoft.com/playwright:v1.61.1-noble (.devcontainer/Dockerfile line 3), which ships browsers for Playwright 1.61.1, and the Makefile (targets at Makefile lines 27-28 and 46-47) never runs `npx playwright install` — it relies entirely on the image's pre-baked browsers. As a result the e2e tier will fail with 'Executable doesn't exist' because no 1.62.0 browsers are present. Fix by bumping the Docker base image tag in .devcontainer/Dockerfile to v1.62.0-noble in the same PR, and update the stale version references in tests/README.md (line 29) and CLAUDE.md (line 91) to match. Verify with a full container `make test` run.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
}
Loading