Repository navigation
feat: add deterministic model glob selection - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the first production slice of the v0.3 model-selection contract from #19 without enabling compatibility overrides yet.
This PR:
model_globsconfiguration while keeping existing exactmodelssemantics unchangedmodels = []fnmatchcasesemanticsexact:<name>/glob:<pattern>provenanceselect_model_groups()API as a compatibility wrapperexplainexplainrejection for models outside all configured selectorsmodel_overridesis configured before the follow-up override implementation existsScope boundary
This PR does not apply any compatibility/evidence overrides and does not change exact/foreign mapping rules. The follow-up slice will implement the strict override whitelist against aggregated group evidence.
Tests
Regressions cover exact-only compatibility, glob-only config, duplicate/empty patterns, strict unmatched globs, case sensitivity, lexical deterministic expansion, first-selector de-duplication/provenance, LiteLLM row-order independence, ineligible glob-selected groups failing aggregation, selection provenance surviving generation/explain, configured list ordering, and fail-fast explain behavior.
Refs #5