feat: generalize monitor wait and apply stability fixes#203
Open
ndev-hoster wants to merge 1 commit into
Open
Conversation
…y fixes - Generalize monitor wait loop in cli.sh: dynamics checks for physically connected external displays (non-eDP, non-LVDS, non-Virtual, non-HEADLESS) using hyprctl and jq, skipping loop if none present - Apply null-safety and try-catch frames to LockScreen.qml to prevent random lockscreen crashes on session lock or screencopy - Add Component.onDestruction hook to Wallpaper.qml to cleanly nullify GlobalStates.wallpaperManager reference and prevent memory leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces critical fixes for Ambxst shell startup synchronization, lockscreen stability, and resource cleanup.
1. Generalizing
cli.shStartup Monitor Wait Loophyprctlandjq.hyprctl monitors all -jto detect if an external monitor (non-eDP, non-LVDS, non-Virtual, non-HEADLESS) is physically connected.disabled: falseinhyprctl monitors -j), sleeping for an additional 1.0s to let the layout settle.quickshellandaxctldaemons.2. Enhancing
LockScreen.qmlNull SafetyGlobalStates.wallpaperManager.currentWallpaperbefore retrieving the frame path, wrapping it in atry-catchblock.root.screenforscreencopyBackground.captureSourceand guardedscreencopyBackground.captureFrame()call.3. Fixing
Wallpaper.qmlResource CleanupComponent.onDestructionclean up to setGlobalStates.wallpaperManager = nullwhen the component is destroyed.