Skip to content

feat: add mobile local verification command - #543

Open
apatafamilycompound123-ops wants to merge 5 commits into
Axionvera:mainfrom
apatafamilycompound123-ops:fix/issue-444-add-mobile-local-verification-command
Open

feat: add mobile local verification command#543
apatafamilycompound123-ops wants to merge 5 commits into
Axionvera:mainfrom
apatafamilycompound123-ops:fix/issue-444-add-mobile-local-verification-command

Conversation

@apatafamilycompound123-ops

Copy link
Copy Markdown

Overview

This PR adds a single local verification command for mobile contributors. Running npm run verify now executes typecheck, lint, tests, and available formatting checks locally, so PRs can be validated before CI and common failures are avoided.

Related Issue

Changes

✅ Local Verification Command

  • [ADD] package.json

    • Adds a verify script that runs typecheck, lint, test, and format:check sequentially.
    • Aligns the local verification command with CI expectations.
  • [MODIFY] .github/pull_request_template.md

    • Adds a checklist item instructing contributors to run npm run verify before submitting.

📚 Documentation & CI Alignment

  • [ADD] docs/CI_REQUIREMENTS.md

    • Documents the npm run verify command, prerequisites, and what each check does.
  • [MODIFY] README.md

    • Adds a "Local Verification" section with a link to docs/CI_REQUIREMENTS.md.
  • [ADD] docs/contributor-self-assessment.md

    • Provides a pre-submit checklist based on the local verification workflow.

Verification Results

npm run verify
✅ typecheck passed
✅ lint passed
✅ tests passed
✅ format check passed

Live acceptance check:
✅ Single `verify` command added
✅ Typecheck, lint, tests, and formatting all run locally
✅ Documentation covers usage
✅ README links to the verification workflow
Acceptance Criteria Status
One local verification command is added npm run verify added to package.json
Command runs typecheck verify runs typecheck
Command runs lint where available verify runs lint
Command runs tests verify runs tests
Documentation explains usage docs/CI_REQUIREMENTS.md documents command and setup
README links to verification workflow ✅ README "Local Verification" section links to docs

Closes #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mobile local verification command

1 participant