feat: Add axserialport wrapper and example - #190
apljungquist wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new wrapper for the Axis Serial Port API and provides an example application demonstrating its usage. Key changes include the implementation of the axserialport wrapper with safe Rust abstractions and binding generation for low‐level FFI, as well as updates to the workspace configuration to integrate the new crates.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/axserialport/src/lib.rs | Implements Rust wrapper functions for the Axis Serial Port API. |
| crates/axserialport/src/gio.rs | Provides GIO-related functionality using the new serial port bindings. |
| crates/axserialport-sys/* | Adds low-level bindings and build script for FFI with axserialport API. |
| apps/axserialport_example/src/main.rs | An example application showcasing the use of the serial port wrapper. |
| Makefile & Cargo.toml | Updated to include the new crates in the workspace. |
apljungquist
changed the title
08fe943 to
4d8efe8
Compare
|
I have been able to test that this doesn't crash. However, since I don't have a camera with a serial port, and I can't connect a loopback cable to the cameras as the instructions say from the virtual loan tool, I'm afraid I'm stuck. Are either of you interested in finishing this example? @guoxe @kjughx |
As in continuing development or just test if it works? |
|
If it compiles, it works. Right? 😅 More likely it will need a few test-fix cycles, so I was thinking the same person would do both to avoid slow handovers and context switching. If it doesn't sound like fun, maybe you know someone who is interested in taking a Free(ky) Friday to learn ACAP/Rust... I'm eager to help us much as I can, be it by doing the development, pair programming or just answer questions. And I'm not partial to what I built, I only want a PoC for the last API. |
|
I realized I don't have access to the hardware necessary to test that this works. |
Change-Id: Id992c2fd13be949a79f9090f7768b8a8e6816431
apljungquist
left a comment
apljungquist
left a comment
There was a problem hiding this comment.
👍 lgtm but I can't approve since I'm listed as the author
No description provided.