Skip to content

chore: Replace acap-build crate with external rs4a-eap #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apljungquist wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Replace acap-build crate with external rs4a-eap #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df1817
Replace acap-build crate with rs4a-eap from git
apljungquist Jul 9, 2026
cf57c34
Upgrade rs4a-eap version
apljungquist Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ jobs:
run: devcontainer up --workspace-folder .
- name: Update generated files
run: devcontainer exec --workspace-folder . make --always-make check_generated_files check_generated_files_container
- name: Update generated without acap-build
run: devcontainer exec --remote-env ACAP_BUILD_IMPL=equivalent --workspace-folder . make check_generated_files_container
- name: Run other checks
run: devcontainer exec --workspace-folder . make check_other
- name: Run miri check
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/on-host-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,14 @@ jobs:
- name: Shell setup
# This step typically needs to be done once per shell session.
# To verify that the procedure has worked, some checks are run as well.
# TODO: Simplify shell session setup; exporting two variables seems excessive
run: |
export ACAP_SDK_LOCATION=$HOME/axis/
source ./init_env.sh
export ACAP_BUILD_IMPL=equivalent
make check_generated_files
debian_and_ubuntu_no_sdk:
runs-on: ubuntu-24.04
# If the sysroots from the ACAP Native SDK are not needed, then the Rust implementation of
# `acap-build` can be used for an easier setup:
# If the sysroots from the ACAP Native SDK are not needed, then the native EAP builder
# (`rs4a-eap`, used by `cargo-acap-build`) can be used for an easier setup:
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -76,6 +74,5 @@ jobs:
run: |
cargo-acap-build -- --package hello_world
env:
ACAP_BUILD_IMPL: equivalent
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
CARGO_TARGET_THUMBV7NEON_UNKNOWN_LINUX_GNUEABIHF_LINKER: arm-linux-gnueabihf-gcc
Loading
Loading