Conversation
…ERROR_NO_VIDEO arm) VdoError::code_name() referenced vdo_sys::VDO_ERROR_NO_VIDEO, which the firmware-11 Native SDK (1.15.1) vdo headers don't define (added in a later SDK), so the crate failed to build against that sysroot with E0425. The arm is diagnostic-only and the '_ => "VDO_ERROR_UNKNOWN"' fallback already covers the code, so dropping it lets vdo compile across both the fw11 (1.15.1) and fw12 (12.1.0) SDKs. If you'd rather keep the label for fw12+, a cfg/build-probe gate works too. Closes AxisCommunications#245.
Collaborator
|
I think we should find a way to compile conditionally with the error code because I don't think the bindings will be particularly useful if we reduce them to supporting only the greatest common denominator. I haven't thought much about exactly how to do this, so I'm happy to discuss options or just go with whatever you propose as long as it sounds reasonable (with the reservation that we may change it down the road if we come up with something that has tangible benefits). But I would like to use this as a starting point (feel free to challenge me if you disagree): We should support the latest minor/micro version within each major version of AXIS OS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245.
VdoError::code_name()referencedvdo_sys::VDO_ERROR_NO_VIDEO, which the firmware-11 Native SDK (1.15.1) vdo headers don't define (it was added in a later SDK), so thevdocrate failed to build against that sysroot:The arm is diagnostic-only and the
_ => "VDO_ERROR_UNKNOWN"catch-all already covers the code, so dropping it letsvdocompile against both the fw11 (1.15.1) and fw12 (12.1.0) SDK sysroots.Verified end-to-end: with this change the crate cross-compiles under
axisecp/acap-native-sdk:1.15.1-{aarch64,armv7hf}-ubuntu22.04and a real ACAP app (on-camera LL-HLS via VDO) runs on an ARTPEC-6 / firmware-11.11 camera.If you'd rather keep the label for fw12+ instead of dropping it, a
cfg/build-probe gate would also work — happy to switch this PR to that approach.