feat(vdo): Expose map and frame additions from SDK 12.11.0 - #262
Open
vsem-azamat wants to merge 1 commit into
Open
vsem-azamat wants to merge 1 commit into
vsem-azamat wants to merge 1 commit into
Conversation
Part of AxisCommunications#244. - `Map` implements `Clone` via `vdo_map_clone`. - `Map::{get,set}_quad32{i,u}` with plain `Quad32i`/`Quad32u` structs instead of the bindgen unions. - `StreamBuffer::utc_timestamp` (`vdo_frame_get_utc_timestamp`). - `StreamBuffer::is_contiguous` (`vdo_buffer_is_contiguous`), documented as the precondition for `as_slice` and `data_copy`. The new `VdoFormat`/`VdoFrameType` AVIF variants and `VdoWdrMode` need no changes: the enums are re-exported from `vdo-sys` as is. The remaining items in the checklist (`VdoChunk`, `VdoZipStreamGdr`, `vdo_channel_*`, typed stream constructors) are not used by this crate yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #244.
Adds
Map: Clone,Map::{get,set}_quad32{i,u}with plainQuad32i/Quad32ustructs instead of the bindgen unions,StreamBuffer::utc_timestampandStreamBuffer::is_contiguous.The AVIF variants and
VdoWdrModealready come through thevdo-sysre-exports, so they need no changes here.Not covered:
VdoChunk,VdoZipStreamGdr, thevdo_channel_*removals and the typed stream constructors (vdo_stream_{rgb,nv12,y800}_new), which this crate does not use yet. I would like to hear how you would prefer the typed constructors to fit intoStreamBuilderbefore adding them.Device tests are extended but not yet run on hardware.