Adjust Subscribable Eventsource API and move reference documentation for persistent streams#4616
Merged
Merged
Conversation
hatzlj
added
Priority 1: Must
hatzlj
changed the title
hatzlj
force-pushed
the
documentation/persistent-streams
branch
2 times, most recently
from
b9e93c3 to
febf7cb
Compare
|
MateuszNaKodach
approved these changes
Jun 3, 2026
hatzlj
force-pushed
the
documentation/persistent-streams
branch
from
5e476d0 to
6beacf5
Compare
hatzlj
requested review from
jangalinski,
laura-devriendt-lemon and
smcvb
and removed request for
a team
hjohn
reviewed
Jun 17, 2026
hjohn
approved these changes
Jun 17, 2026
hjohn
left a comment
hjohn
left a comment
Contributor
There was a problem hiding this comment.
The problem I pointed out was pre-existing so, LGTM.
In the course of reintroducing the persistent streams feature to Framework 5, we move the documentation to the Axoniq Framework repository.
…batch consumer The javadoc of the `org.axonframework.messaging.core.SubscribableEventSource.subscribe` function clearly states that the processing context for the batch consumer bi-function may be null. We should reflect this with the appropriate `@Nullable` annotation.
hatzlj
force-pushed
the
documentation/persistent-streams
branch
from
6beacf5 to
404f874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the course of reintroducing the persistent streams feature to Framework 5, we
SubscribableEventSourceto reflect the fact that the processing context supplied to the event batch consumer bi-function might be null (already stated as such in the javadoc and handled as such in the places where it is used)