[#4643 | Port] AggregateBasedJpaEventStorageEngine#stream loops until StreamingCondition matching events are retrieved#4686
Merged
Merged
Conversation
Adjust the AggregateBasedJpaEventStorageEngine#streaming to keep querying events until some match the given StreamingCondition. If we don't do this, there's a chance that the batch is empty, stalling the ContinuesMessageStream until a new event is appended. Thus, essentially blocking a consumer like the PooledStreamingEventProcessor, potentially indefinitely. #4625 (cherry picked from commit d7284c2)
smcvb
added
Type: Bug
smcvb
added
the
Type: Port
smcvb
requested review from
hatzlj,
laura-devriendt-lemon and
zambrovski
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a port of #4684.
This port will resolve #4643.