[Port] fix(migration): honor skipTests property#4700
Merged
Conversation
The migration module bound surefire's skipTests to the dedicated
`skipAf4RecipeTests` flag, so a plain `-DskipTests` (or the IDE "Skip
Tests" toggle) left these tests running while every other module skipped.
Default `skipAf4RecipeTests` to `${skipTests}` so the standard flag also
skips them, while keeping `-DskipAf4RecipeTests=true` as a dedicated
switch the release build uses to skip only these tests (and the AF4 stub
download) without skipping the rest of the build's tests.
MateuszNaKodach
requested review from
hatzlj,
laura-devriendt-lemon and
zambrovski
and removed request for
a team
MateuszNaKodach
changed the title
MateuszNaKodach
added
Priority 1: Must
smcvb
added
Type: Port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
migrationmodule binds surefire'sskipTeststo the dedicatedskipAf4RecipeTestsflag:Because
skipAf4RecipeTestshad no default, a plain-DskipTests(or the IntelliJ "Skip Tests" toggle, which passes-DskipTests) had no effect on this module -- the AF4 recipe tests kept running while every other module's tests were skipped.Change
Default
skipAf4RecipeTeststo${skipTests}so the standard flag also skips these tests, while keeping-DskipAf4RecipeTests=trueas a dedicated switch to skip only these tests (and the AF4 stub download).Behavior
-DskipTests=true/ IDE "Skip Tests"-DskipAf4RecipeTests=true-DskipAf4RecipeTests=true)The release path is unchanged: it passes
-DskipAf4RecipeTests=trueexplicitly (which overrides the new default), so it still skips only the migration tests, not the whole build.When
skipTestsis unset,${skipTests}stays an unresolved literal and parses asfalse, so the default of running tests is preserved.Note
This ports #4631 (originally merged to
axon-5.1.x) ontomain. Therewrite-recipe-bom.versionconflict during cherry-pick was resolved in favor of main's current3.33.0.